Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused lifetimes. #42127

Merged
merged 1 commit into from
May 21, 2017
Merged

Remove unused lifetimes. #42127

merged 1 commit into from
May 21, 2017

Conversation

clarfonthey
Copy link
Contributor

@clarfonthey clarfonthey commented May 20, 2017 •
edited
Loading

This was a typo that made it onto master. Noted by @dtolnay in #42127.

Also note #41960 which suggests warning these.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@clarfonthey clarfonthey mentioned this pull request May 20, 2017
Closed
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 20, 2017

📌 Commit 6119f98 has been approved by Mark-Simulacrum

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 20, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 20, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42127 - clarcharr:lifetimes, r=Mark-Simulacrum
382c0eb 
Remove unused lifetimes.

This was a typo that made it onto master. Noted by @dtolnay in rust-lang#42127.

Also note rust-lang#41960 which suggests warning these.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 20, 2017
Merged
bors added a commit that referenced this pull request May 21, 2017
@bors
Auto merge of #42130 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
7ac844f 
Rollup of 6 pull requests

- Successful merges: #41892, #42062, #42091, #42093, #42098, #42127
- Failed merges:
@bors bors merged commit 6119f98 into rust-lang:master May 21, 2017
@clarfonthey clarfonthey deleted the lifetimes branch May 27, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clarfonthey @rust-highfive @Mark-Simulacrum @bors @alexcrichton